Skip to content

Make appResourcesChanged check to be executed per platform #3619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented May 25, 2018

In case when when something is changed in app/App_Resources/iOS folder, tns run android command executes full application build. Actually there is no need to rebuild the application in this case. Make the appResourcesDirectoryChanged to be checked per platform so no rebuild is triggered.

PR Checklist

@Fatme Fatme added this to the 4.1.0 milestone May 25, 2018
@Fatme Fatme changed the base branch from master to release May 25, 2018 22:06
@Fatme Fatme force-pushed the fatme/fix-app-resources-changed branch from 25fe264 to d04fe89 Compare May 25, 2018 22:10
@Fatme
Copy link
Contributor Author

Fatme commented May 26, 2018

run ci

@rosen-vladimirov rosen-vladimirov modified the milestones: 4.1.0, 4.1.1 May 28, 2018
@Fatme Fatme merged commit dfd687b into release Jun 1, 2018
@Fatme Fatme deleted the fatme/fix-app-resources-changed branch June 1, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants