Add spinner when checking for NativeScript components versions #3457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
force-pushed
the
fatme/components-spinner
branch
from
0268ced to
fec6b4d
Compare
Fatme
force-pushed
the
fatme/components-spinner
branch
from
fec6b4d to
b51742e
Compare
lib/services/versions-service.ts
Outdated
| import { createTable } from "../common/helpers"; | ||
|
|
||
| export enum VersionInformationType { | ||
| UpToDate, |
There was a problem hiding this comment.
You could assign values here, should you decide to follow my suggestion in mobile-cli-lib's PR
lib/services/versions-service.ts
Outdated
| const spinner = this.$terminalSpinnerService.createSpinner(); | ||
| spinner.text = componentInformation.message; | ||
|
|
||
| if (componentInformation.type === VersionInformationType.UpToDate) { |
There was a problem hiding this comment.
We could use a switch here instead of multiple if statements
Fatme
force-pushed
the
fatme/components-spinner
branch
3 times, most recently
from
d398d48 to
7de3e72
Compare
|
run ci |
Currently when doctor command is executed, NativeScript components versions information is displayed as table. With this PR NativeScript components versions will be displayed with terminal spinners. In case when component is up to date with latest available version, success spinner will be displayed. In case when for component update is available, warn spinner will be displayed. In case when component is not installed, fail spinner will be displayed. This PR changes also the behaviour of `tns info` command. When `tns info` command is executed, NativeScript components versions information also will be displayed with terminal spinners.
Fatme
force-pushed
the
fatme/components-spinner
branch
from
7de3e72 to
c859f5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when doctor command is executed, NativeScript components versions information is displayed as table. With this PR NativeScript components versions will be displayed with terminal spinners.
In case when component is up to date with latest available version, success spinner will be displayed.
In case when for component update is available, warn spinner will be displayed.
In case when component is not installed, fail spinner will be displayed.
This PR changes also the behaviour of
tns infocommand. Whentns infocommand is executed, NativeScript components versions information also will be displayed with terminal spinners.Should be merged with this PR telerik/mobile-cli-lib#1066