fix(nsconfig):app resources not filtered on prepare #3429
Conversation
|
Fixes #3428 |
| @@ -17,7 +17,7 @@ export class AppFilesUpdater { | |||
|
|
|||
| // exclude the app_resources directory from being enumerated | |||
| // for copying if it is present in the application sources dir | |||
| const appResourcesPathNormalized = path.normalize(projectData.appResourcesDirectoryPath + "\\"); | |||
| const appResourcesPathNormalized = path.normalize(projectData.appResourcesDirectoryPath + path.sep); | |||
There was a problem hiding this comment.
why do you need / at the end ?
There was a problem hiding this comment.
@rosen-vladimirov
So that there are no false-positives when there is a directory which contains a similar name.
For example, if your resources remain as App_Resources, but you've got another App_Resources123 directory, you don't want that filtered out. Similarly if you rename the resources directory to something more generic like resources, and if you have another resources_home_page, the latter should not be filtered out of the application files.
There was a problem hiding this comment.
@Pip3r4o added it so we can filter more accurately. For example if you have Resources folder named "native" and folder named "native_classes" we want to filter only files inside "native".
|
run ci |
1 similar comment
|
run ci |
petekanev
changed the title
Fixes #3428