Skip to content

Getting started improvements #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 7, 2018
Merged

Getting started improvements #3418

merged 6 commits into from
Mar 7, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Mar 4, 2018

Should be merged after this NativeScript/nativescript-doctor#28

@Fatme Fatme force-pushed the fatme/info-messages branch from edb8e06 to 7302f38 Compare March 6, 2018 09:09
Copy link
Contributor

@Mitko-Kerezov Mitko-Kerezov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 after setting the correct references in package.json

package.json Outdated
@@ -30,6 +30,7 @@
"mobile"
],
"dependencies": {
"@types/ora": "^1.3.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please save an exact version of this package

package.json Outdated
"open": "0.0.5",
"ora": "^2.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please save an exact version of this package

package.json Outdated
@@ -56,8 +57,9 @@
"minimatch": "3.0.2",
"mkdirp": "0.5.1",
"mute-stream": "0.0.5",
"nativescript-doctor": "0.9.0",
"nativescript-doctor": "file:../nativescript-doctor/nativescript-doctor-0.9.0.tgz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update this reference once nativescript-doctor is released

@Fatme Fatme changed the title Respect getInfos() method from nativescript-doctor package Getting started imporvements Mar 6, 2018
Copy link
Contributor

@Mitko-Kerezov Mitko-Kerezov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

@Fatme Fatme changed the title Getting started imporvements Getting started improvements Mar 6, 2018
@Fatme Fatme force-pushed the fatme/info-messages branch 2 times, most recently from 6312a33 to 7938cfe Compare March 6, 2018 14:47
@Fatme Fatme force-pushed the fatme/info-messages branch from 7938cfe to 8d46b65 Compare March 7, 2018 06:52
@Fatme Fatme force-pushed the fatme/info-messages branch from 8d46b65 to d61fe60 Compare March 7, 2018 07:12
@Fatme Fatme merged commit 360b9c9 into master Mar 7, 2018
@Fatme Fatme deleted the fatme/info-messages branch March 7, 2018 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants