-
-
Notifications
You must be signed in to change notification settings - Fork 196
Getting started improvements #3418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
edb8e06
to
7302f38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 after setting the correct references in package.json
package.json
Outdated
@@ -30,6 +30,7 @@ | |||
"mobile" | |||
], | |||
"dependencies": { | |||
"@types/ora": "^1.3.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please save an exact version of this package
package.json
Outdated
"open": "0.0.5", | ||
"ora": "^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please save an exact version of this package
package.json
Outdated
@@ -56,8 +57,9 @@ | |||
"minimatch": "3.0.2", | |||
"mkdirp": "0.5.1", | |||
"mute-stream": "0.0.5", | |||
"nativescript-doctor": "0.9.0", | |||
"nativescript-doctor": "file:../nativescript-doctor/nativescript-doctor-0.9.0.tgz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update this reference once nativescript-doctor
is released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me
6312a33
to
7938cfe
Compare
7938cfe
to
8d46b65
Compare
8d46b65
to
d61fe60
Compare
Should be merged after this NativeScript/nativescript-doctor#28