Skip to content

Update marked dependency #3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2018
Merged

Update marked dependency #3300

merged 1 commit into from
Jan 15, 2018

Conversation

Mitko-Kerezov
Copy link
Contributor

@Mitko-Kerezov Mitko-Kerezov commented Jan 5, 2018 •
edited
Loading

Update marked dependency to latest version and regenerate npm-shrinkwrap.
This is done as marked 0.3.6 has some security vulnerabilities, which have been resolved in 0.3.9 as can be seen from the Github analysis

Ping @TsvetanMilanov @KristianDD @rosen-vladimirov

@Mitko-Kerezov Mitko-Kerezov self-assigned this Jan 5, 2018
@KristianDD
Copy link
Contributor

Could you add some more information why we update the dependency please.

@Mitko-Kerezov
Copy link
Contributor Author

@KristianDD modified the PR description to point out why this change is proposed

rosen-vladimirov
rosen-vladimirov suggested changes Jan 8, 2018
View reviewed changes
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shrinkwrap is incorrect - some optional dependencies have been removed. It looks like the shrinkwrap has been generated on Windows with npm version below 5.6.0

@rosen-vladimirov
Copy link
Contributor

I've updated the branch with correct shrinkwrap. I've also updated marked version to 0.3.12

@rosen-vladimirov rosen-vladimirov merged commit f35dbfc into master Jan 15, 2018
@rosen-vladimirov rosen-vladimirov deleted the kerezov/update-marked branch January 15, 2018 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristianDD KristianDD KristianDD approved these changes

@rosen-vladimirov rosen-vladimirov rosen-vladimirov approved these changes

@TsvetanMilanov TsvetanMilanov TsvetanMilanov approved these changes

Assignees

@Mitko-Kerezov Mitko-Kerezov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mitko-Kerezov @KristianDD @rosen-vladimirov @TsvetanMilanov