Remove App_Resources, when the changes are in the other files. #2701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we look for "FileChanges" we divide them in categories:
-- FileChanged
-- AppResources Changed
The FileChanged is triggered for all files, excluding the ones in App_Resource directory. The CopyAppFiles method copies all /app files though, therefore including the App_Resource files. The functionality to clean-up the App_Resources folder from the /app is in the prepare which is not executed in this case.
This will be refactored, as soon as I add some tests to cover the functionality and ensure we don't do introduce many regression bugs.