Fix installation of latest compatible version #1552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI should install latest compatible version of runtimes, based on it's current version. For example in case CLI's version is "1.6.0", when `tns platform add android` is called, CLI should install latest 1.6.x version of android runtime, no matter if 1.7.x exists. This was not working correctly as it was using beta versions, incorrect sorting, etc. Fix it by using semver methods and always use the `@latest` tag of the package. In case it doesn't match CLI version, try finding latest matching tag with maxSatisfying method of semver, which dismisses beta versions. Required for publishing `@next` in npm.
|
👍 |
1 similar comment
|
👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Mar 1, 2016
…tection Fix installation of latest compatible version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI should install latest compatible version of runtimes, based on it's current version. For example in case CLI's version is "1.6.0", when
tns platform add androidis called, CLI should install latest 1.6.x version of android runtime, no matter if 1.7.x exists.This was not working correctly as it was using beta versions, incorrect sorting, etc.
Fix it by using semver methods and always use the
@latesttag of the package. In case it doesn't match CLI version, try finding latest matching tag with maxSatisfying method of semver, which dismisses beta versions.Required for publishing
@nextin npm.