Skip to content

Change setting of profile-dir #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2014
Merged

Conversation

rosen-vladimirov
Copy link
Contributor

Change default profile-dir to be:

  • %localappdata%.nativescript-cli for Windows
  • ~/.local/share/.nativescript-cli for MacOS and Linux

Update common lib where the following change is applied: DefaultValue is passed to the setProfileDir method. Different CLI-s have different defaultProfileDirs. setProfileDir method will use the passed on the command line profile-dir or the default one passed as parameter to the function.

@ns-bot
Copy link

ns-bot commented Nov 14, 2014

Test PASSed.

@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/fix-cache-folder branch from 1fb3934 to 06f9f28 Compare November 14, 2014 08:09
@ns-bot
Copy link

ns-bot commented Nov 14, 2014

Test PASSed.

@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/fix-cache-folder branch from 06f9f28 to ccd4c8b Compare November 14, 2014 09:24
@ns-bot
Copy link

ns-bot commented Nov 14, 2014

Test FAILed.

1 similar comment
@ns-bot
Copy link

ns-bot commented Nov 14, 2014

Test FAILed.

@rosen-vladimirov
Copy link
Contributor Author

run ci

Change default profile-dir to be:
 - %localappdata%\.nativescript-cli for Windows
 - ~/.local/share/.nativescript-cli for MacOS and Linux

Update common lib where the following change is applied: DefaultValue is passed to the setProfileDir method. Different CLI-s have different defaultProfileDirs. setProfileDir method will use the passed on the command line profile-dir or the default one passed as parameter to the function.
@ns-bot
Copy link

ns-bot commented Nov 17, 2014

Test PASSed.

@Fatme
Copy link
Contributor

Fatme commented Nov 17, 2014

👍

rosen-vladimirov added a commit that referenced this pull request Nov 17, 2014
@rosen-vladimirov rosen-vladimirov merged commit b22ca15 into master Nov 17, 2014
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-cache-folder branch November 17, 2014 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants