Fix StringCommandParameter #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
rosen-vladimirov
force-pushed
the
vladimirov/fix-hierarchical-commands
branch
from
a6cb7a6 to
804fab9
Compare
|
ok to test |
|
Test PASSed. |
Update common lib where the following change is applied: when injector tries to resolve StringCommandParamater, it raises error as it's unable to use the current constructor. Add StringParameterBuilder class that is used to generate string parameters. Add createMandatoryParameter method to it, so it will generate mandatory parameter with specified error message. Add IStringParameterBuilder interface. The idea is to use stringParameter from injector resolver when the parameter will not be mandatory and to use the builder when a more complicated logic is needed. Also fixed FileSystemStub as it had to implement new method from IFileSystem
rosen-vladimirov
force-pushed
the
vladimirov/fix-hierarchical-commands
branch
from
804fab9 to
988fc2a
Compare
|
Test PASSed. |
|
👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Nov 10, 2014
…-commands Fix StringCommandParameter
|
👍 |
|
Can one of the admins verify this patch? |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update common lib where the following change is applied: when injector tries to resolve StringCommandParamater, it raises error as it's unable to use the current constructor. Add StringParameterBuilder class that is used to generate string parameters. Add createMandatoryParameter method to it, so it will generate mandatory parameter with specified error message. Add IStringParameterBuilder interface.
The idea is to use stringParameter from injector resolver when the parameter will not be mandatory and to use the builder when a more complicated logic is needed.
Also fixed FileSystemStub as it had to implement new method from IFileSystem