Project service integration tests and unit tests for platform service #108
+731
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,6 @@ | |||
| interface IProjectIntegrationTest { | |||
There was a problem hiding this comment.
Do we really need this interface? What is the need for this abstraction in the tests? 😄
Fatme
force-pushed
the
fatme/tests
branch
4 times, most recently
from
34025a8 to
9308153
Compare
| @@ -1,6 +1,6 @@ | |||
| interface INodePackageManager { | |||
| getCacheRootPath(): IFuture<string>; | |||
| addToCache(packageName: string): IFuture<void>; | |||
| addToCache(ppackageName: string, version: string): IFuture<void>; | |||
There was a problem hiding this comment.
looks like the first parameter is mis-spelled: ppackage
|
It looks like tests do not complete successfully under Windows |
| @@ -1,33 +1,189 @@ | |||
| /// <reference path=".d.ts" /> | |||
|
|
|||
| import yok = require('../lib/common/yok'); | |||
There was a problem hiding this comment.
missing "use strict"; for turning on strict mode
|
Test FAILed. |
|
👍 |
Fatme
added a commit
that referenced
this pull request
Oct 2, 2014
Project service integration tests and unit tests for platform service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.