[IOS]Unexpected duplicate tasks

[farfromrefug]

When i am in a working env dev with npm links i might end up with an XCode build error Unexpected duplicate tasks
It is due to native deps being added twice.
For example my plugin nativescript-gesturehandler comes with a framework.
In my current case i have it in my app package.json but also as a dependency of another plugin.
Consequently i have nativescript-gesturehandler in:

• node_modules/nativescript-gesturehandler
• node_modules/nativescript-chart/node_modules/nativescript-gesturehandler

Could you filter duplications when creating the XCode project and adding modules targets?

[rosen-vladimirov]

Hey @farfromrefug ,
Thanks for the suggestions. I've created a PR that should resolve this issue.

[rosen-vladimirov]

After latest fixes (currently available in CLI's next version), CLI will detect if NativeScript plugin exists multiple times in node_modules. In case that's the case, CLI will check the versions of the plugin in each occurrence and will apply the following rules:

• in case all versions are the same, CLI will use the native code from the version which is topmost in node_modules. You can reproduce this by executing:

tns create myApp --js
cd myApp
npm i --save-exact nativescript-ui-listview@8.0.1 nativescript-ui-core@4.0.0
cd node_modules/nativescript-ui-listview
npm i --production
cd ../../
tns prepare ios/android

This must produce warning that nativescript-ui-core exists in multiple locations.

• in case there's difference in the versions, CLI will throw an error:
  You can reproduce this by executing:

tns create myApp --js
cd myApp
npm i --save-exact nativescript-ui-listview@8.0.1 nativescript-ui-core@4.0.0 nativescript-ui-autocomplete@5.0.0
tns prepare ios/android

NOTE: the error message will guide you to delete package-lock.json (or other configuration file if it exists in your project). CLI checks if there's npm-shrinkrwrap.json, package-lock.json, yarn.lock and pnpm-lock.yaml.

[farfromrefug]

@rosen-vladimirov awesome! will test it and report any error. Will actually leave this open until i can confirm it works

[rosen-vladimirov]

After some additional investigation, we've decided to implement the following:

1. For Android - analyze the dependencies tree and show debug messages (visible when you pass --log debug in case there are same versions of plugin in node_modules.
2. For iOS search for .framework in the NativeScript plugins.
   2.1 In case the same framework comes from different plugins - show error message
   2.2 In case the same framework comes from the same plugin, but with different versions in node_modules - show error message
   2.3 In case the same framework comes from the same versions of a plugin - show warning and use only one of the instances

[rosen-vladimirov]

Hey @farfromrefug ,
As the feature has been implemented and released, I'm closing this issue. In case you notice any problems or concerns, please open a new bug report.

[farfromrefug]

@rosen-vladimirov right sorry. Forgot to mention that right now it seems perfect. Will notify if i see any issue

[mvnidheesh1992]

Hi @rosen-vladimirov

getting error like this below

error: Unexpected duplicate tasks:

1. Target 'demo' (project 'demo'): CodeSign /upgrade/nativescript-plugin/demo/platforms/ios/build/Debug-iphonesimulator/demo.app/Frameworks/TNSWidgets.framework
2. Target 'demo' (project 'demo'): CodeSign /upgrade/nativescript-plugin/demo/platforms/ios/build/Debug-iphonesimulator/demo.app/Frameworks/TNSWidgets.framework
   error: Multiple commands produce '/upgrade/nativescript-plugin/demo/platforms/ios/build/Debug-iphonesimulator/demo.app/Frameworks/TNSWidgets.framework':
3. Target 'demo' has copy command from '/upgrade/nativescript-plugin/demo/node_modules/@cn/nativescript-mlkit-plugin/node_modules/@nativescript/core/platforms/ios/TNSWidgets.xcframework/ios-arm64_x86_64-simulator/TNSWidgets.framework' to '/upgrade/nativescript-plugin/demo/platforms/ios/build/Debug-iphonesimulator/demo.app/Frameworks/TNSWidgets.framework'
4. Target 'demo' has copy command from '/upgrade/nativescript-plugin/demo/node_modules/@nativescript/core/platforms/ios/TNSWidgets.xcframework/ios-arm64_x86_64-simulator/TNSWidgets.framework' to '/upgrade/nativescript-plugin/demo/platforms/ios/build/Debug-iphonesimulator/demo.app/Frameworks/TNSWidgets.framework'

package.json

"devDependencies": {
	"typescript": "~4.0.0",
	"prompt": "^1.2.0",
	"rimraf": "^3.0.2",
	"tslint": "^5.12.1",
	"semver": "^7.3.5",
	"@nativescript/types": "^8.1.1"
},
"dependencies": {
	"@nativescript/core": "^8.1.1",
	"@nativescript/hook": "^2.0.0",
	"path": "^0.12.7"
}

could you please help me to fix this issue