Unify and simplify workflows of build-related commands

[teobugslayer]

Problem: Currently, the commands which include build - related steps differ slightly in their semantics, parameters and work flows.

Solution: Unify as much as possible but only where make sense.

Remark: All commands should work without specifying a platform if it is already added to the project. If more than one platform is added we should execute the command on all of them. If a user wants to run a particular platform she will be able to specify it as it currently works.

Prepare - stays as is

Build - stays as is

Deploy - does not work for emulators, does not run the app
-- device

Run - based on deploy
-- device
-- emulator android (device)
-- emulator ios

by default - build for simulator. Can be overridden by command line parameter. run [ios] --device. For android, running --geny instance must be reused

Debug = run + start debugger. works for android & ios, devices & emulators

Emulate = run --emulator. emulate --geny = run --geny

[rosen-vladimirov]

Based on the description above, I've prepared the exepected behavior of the commands.
I've found some cases, that are confusing and I'm not sure what is the expected behavior (check the table at the end).

platform add

Usage:

• platform add <platform1> - add specified platform
• platform add <platform1> <platform2> - add all specified platforms

prepare

Usage:

• tns prepare - prepares the project for all installed platforms, for example if the project is targeting android and ios, this command will prepare it for both of them
• tns prepare <platform> - prepares the project for all specified platforms. In case the specified platform is not added, add it and prepare it.

build

Usage:

• tns build - prepare and build the project for all installed platforms
• tns build <platform> - prepare and build the project for specified platform

build for device or for emulator

check the table at the end for information which build should be executed.

deploy

Usage:

• tns deploy - prepare and build the project for all installed platforms. After that deploy the project on all currently running devices and emulators.
• tns build <platform> - prepare and build the project for specified platform. After that deploy the project on all currently running devices and emulators of specified platform.
• tns build <platform> --device <deviceId> - prepare and build the project for specified device (for Android make sure to check is this device or emulator). Deploy the project on the specified device.

run

Usage:

• tns run - prepare and build the project for all installed platforms. After that deploy the project on all currently running devices and emulators. Finally run the project on all of them.
• tns run <platform> - prepare and build the project for specified platform. After that deploy the project on all currently running devices and emulators of specified platform. Finally run the project on all of them.
• tns run <platform> --device <deviceId> - prepare and build the project for specified device (for Android make sure to check is this device or emulator). Deploy the project on the specified device and start it.

debug

We have to select device for debugging, we cannot debug on all devices.

• tns debug - if there are more than one device attached, prompt the user to select device on which to debug. If there are no devices attached, prompt user to select platform and start debugging on emulator.
• tns debug <platform> - prompt user to select device and if such is not found, start debugging on emulator.

Building for emulator or for device

The table below illustrates different use cases when both Android and iOS platforms are added to your project.

#	Commands(right) \ scenario(below)	run	run android	run ios
1.	no devices attached, no emulators running	build Android and ios for emulator and run each of them in emulator	build only for android and run in emulator	build only for ios and run in emulator
2.	At least one Android device and at least one iOS device attached	buld Android and iOS for device and run on the devices	build only for Android and run on android devices	build only for iOS and run on iOS devices
3.	At least one Android device	build for iOS emulator and run in it, build for Android and run on device or build only for Android and run on devices	build for Android and run on the attached devices	build for iOS emulator and run in it
4.	At least one iOS device	build for iOS device and run in it, build for Android and run in emulator or build only for iOS device and run in it	build for Android emulator and run in it	build and run on iOS devices
5.	Many Android and iOS device	buld Android and iOS for device and run on the devices	build only for Android and run on android devices	build only for iOS and run on iOS devices
6.	At least one iOS device and iOS emulator	For iOS: build for device or build for emulator or build for device and for emulator Should we build for Android and run in emulator?	build for Android and run in emulator	build for device or build for emulator or build for device and for emulator
7.	At least one iOS device and at least one Android emulator	build iOS for device and run in it, build for Android and run in emulator	build for Android and run in emulator	build for iOS device and run on the device
8.	At least one Android device and iOS emulator	build for Android and run on the device, build iOS for emulator and run in it	build for Android and run on the device	build iOS for emulator and run in it

As you can see there are some "critical" points here. First one is what to do in case user had not specified platform and there's a device attached from only one platform - should we use only the platform from the device attached or we should execute the command for both platforms (using emulator for the second one).
Also if there are iOS device and iOS emulator currently running, should we build two times (one for each of them) and deploy on both devices.

NOTE: When we run the app on multiple platforms, we must disable console logging (set justlaunch to true).

[Fatme]

I'm voting for the following workflow:

• tns build ios - builds only for ios. If the user has not added ios platform, CLI should add the platform.
• tns build android - builds only for android. If the user has not added android platform, CLI should add the platform.
• tns build ios android - builds for ios and android. If the user has not added the platforms, CLI should add the platforms.
• tns build - looks for attached devices/emulators. If any builds for the corresponding platform/platforms. If no devies/emulators found, builds for added platforms.

[Mitko-Kerezov]

Neatly organized table - well done!
IMO when a user runs such a command without specifying a platform tns CLI should execute the command for all platforms, meaning - even if you don't have a device or an emulator running for a particular platform, the CLI should start an emulator up for you.
My view of this derives from the fact that if one would want to build/run/deploy only for a specific platform, one should type in the command name, along with that platform's name - else there would be no difference between run and run <platform> behavior in some cases.

As for the case with an iOS device along with an emulator my vote goes to building for all of them.
When users have both a device attached and an emulator running my guess is they want to test out the functionality for different iOS versions, hence we should execute for both.

[ikoevska]

My vote goes for the following.

When no platform is specified but there is at least one physical device/emulator connected/running - build, deploy or run for the attached device/process only.
In such cases, I would consider not specifying a platform a shortcut for executing the command on all my connected/running devices/emulators whatever they are. Also, I wouldn't want emulators popping up all over the place slowing down my machine and moving the focus away from my console.

In the cases where we don't find a connected device and choose to launch the emulator, we should log a message that no physical devices were detected, so we're launching the emulator.

[teobugslayer]

I second @ikoevska. In my experience, although I have many attached device, my attention is always at a particular task at hand and I ignore devices of the "wrong" kind.

Also, building for android, ios device and ios emulator is a very slow operation. That's why I prefer an approach "when in doubt, ask the user". I.e. when there are 2 platforms added and 2 kind of devices, just ask the user which one to use, either interactively or by requiring a special command line parameter.