Skip to content

Changes to .js files located in node_modules causes the livesync to take upto 30 sec #4500

Closed
@VladimirAmiorkov

Description

@VladimirAmiorkov

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 5.3.0
  • Cross-platform modules:
  • Android Runtime:
  • iOS Runtime: 5.3.1
  • Plugin(s):

Describe the bug
Tested on iOS

To Reproduce

  1. Start the sample project linked bellow with tns run ios --syncAllFiles
  2. Wait for the app to deploy
  3. Go to node_modules/nativescript-ui-listview/ui-listview.js and find createNativeView and add this.height = 200; to that function.
  4. This will trigger a change detection of the CLI and the app will be prepared and deployed after around 20-30 sec

Expected behavior
After the above changes to the ui-listview.js file, the file is synced the same way all JS files located in the app folder are synced (really fast :) ).

Sample project
Can be found here.

Additional context
Log from console when changes to a JS file in node_modules are made:

Preparing project...
Installing pods...
Analyzing dependencies
Downloading dependencies
Using SDWebImage (5.0.0-beta3)
Generating Pods project
Integrating client project
Sending stats
Pod installation complete! There is 1 dependency from the Podfile and 1 total pod installed.

[!] Automatically assigning platform ios with version 9.0 on target demo because no platform was specified. Please specify a platform for this target in your Podfile. See https://guides.cocoapods.org/syntax/podfile.html#platform.
Project successfully prepared (iOS)
Successfully transferred ui-listview.js on device CA4FE147-D326-444F-96CD-7F74BC5D2AA6.
Restarting application on device CA4FE147-D326-444F-96CD-7F74BC5D2AA6...
Successfully synced application org.nativescript.demo on device CA4FE147-D326-444F-96CD-7F74BC5D2AA6.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions