Show warning for deprecated short imports/require used in application

[rosen-vladimirov]

Is your feature request related to a problem? Please describe.
In NativeScript 5.2.0 short imports like import * as application from "application"; are deprecated, i.e. support for them will be removed in a future version. It would be great in case CLI can analyze the application and report for such imports used in the app.
NOTE: Same is applicable for const application = require("application");

Describe the solution you'd like
During project build/run, CLI should analyze application's code and inform for used short imports. Same is applicable when running tns doctor inside project directory.

Describe alternatives you've considered
TSLint rule can do the same for TypeScript projects, but it will not work for JS ones. Also the IDE should have integration with TSLint to see the warning.

[rosen-vladimirov]

NOTE: Until now, we were able to use short imports/requires for all packages coming from tns-core-modules, i.e. all directories from here: https://github.com/NativeScript/NativeScript/tree/master/tns-core-modules

This means, that we were able to write:

const fileSystem = require("file-system"); // In JS Project
import * as fileSystem from "file-system"; // In TS Project

From now on, in case you have such short imports/require, during tns doctor, tns prepare <platform>, tns run <platform>, tns build <platform> , tns debug <platform> and tns test <platform>, CLI will notify you that these short imports are deprecated and you should replace them in your code.

CLI will not notify you for short imports inside node_modules directory.

[tdhman]

Hello,
After upgrading to NS 5.2.0, I got a lot of warning because of short import in my project's assets. Since my application will need to execute some static javascript resources in webview, I have added these js as static assets under the folder app/assets, but when build the app, the cli show warning reports for also my js files. Is there any way to turn off the verification for resource files ?
Thanks.

[rosen-vladimirov]

Hey @tdhman ,
Can you please post an example of some warnings generated for your application, so we can investigate them?

[tdhman]

Hello,
This is one of the import warning I got, actually I got this for every js file in my assets folder.

In file /../app/assets/www/IM.js line <This is content of my minified js>: is short import. Add tns-core-modules/ in front of the required/imported module.

[rosen-vladimirov]

Hey @tdhman ,
Is it possible to send us the minified js file, so we can investigate the issue further. We have an idea what's going wrong, but it will be great in case you can send us the real world scenario for this case.
In case you do not want to send it here, you can find me in the NativeScript Community Slack - search for vladimirov