ui-core dependency needs cleanup - causing release build issues

[tgpetrov]

From @NathanWalker on March 19, 2018 18:52

With a standard package.json using more than 2 individual ui-* package as follows:

Will cause UICore.framework to be added multiple times to project for each ui-* package:

Causing these problems:

This is critical.

Copied from original issue: ProgressNS/nativescript-ui-feedback#580

[tgpetrov]

From @NathanWalker on March 19, 2018 18:52

@bugventure @vchimev ^

[tgpetrov]

From @radeva on March 20, 2018 9:25

Thanks @NathanWalker for reporting this. Could you specify which version of npm are you using?
I tried with npm 5.6.0 to reproduce this but without any luck. Here are the steps I tried:

• tns create myapp
• cd myapp
• npm i nativescript-ui-sidedrawer --save
• npm i nativescript-ui-listview --save

Could you these steps on your side and get back with the result?

In the meantime for the application where you experience this issue, could you remove node_modules, package-lock.json and try to install the dependencies again.

[tgpetrov]

From @NathanWalker on March 20, 2018 17:1

@radeva I'm using node 9.4.0 and 5.6.0. When I generate a new simple project with your steps, it's okay. However on my larger project, same problem occurs after a full clean and reinstall, I have to manually open XCode project and remove the extra TNSCore everytime.
This is the full dependency list:

"nativescript-angular": "^5.2.0",
    "nativescript-background-http": "^3.1.0",
    "nativescript-coachmarks": "~2.0.3",
    "nativescript-fancyalert": "^1.1.2",
    "nativescript-image-zoom": "^1.1.1",
    "nativescript-loading-indicator": "^2.4.0",
    "nativescript-ngx-fonticon": "^4.0.0",
    "nativescript-payments": "0.0.10",
    "nativescript-plugin-firebase": "~5.1.8",
    "nativescript-social-share": "^1.5.0",
    "nativescript-theme-core": "^1.0.4",
    "nativescript-ui-listview": "^3.5.1",
    "nativescript-ui-sidedrawer": "^3.5.1",

[tgpetrov]

From @radeva on March 20, 2018 17:27

@NathanWalker The thing is that this is not expected behaviour and we would like to know what's causing it in order to decide what's the proper way to fix it. I'll check with these dependencies and the same version of node (have in mind 9.X is not LTS so it might be causing issues as well) and get back to you.

Could you send me the whole package.json? And also let me know the NativeScript version you're using?

[tgpetrov]

From @bradmartin on March 20, 2018 22:23

@NathanWalker do you have this output during a build:

2018-03-20 17:08:30.817 xcodebuild[13590:373842] [MT] IDEDistribution: Step failed: <IDEDistributionPackagingStep: 0x7faef788d720>: Error Domain=IDEFoundationErrorDomain Code=1 "Failed to verify bitcode in TNSCore.framework/TNSCore:
error: Cannot extract bundle from /var/folders/qn/rgqwl65s4xzcvkm3_zfc31c80000gn/T/XcodeDistPipeline.bH9/Root/Payload/evalmobile.app/app/tns_modules/nativescript-ui-listview/node_modules/nativescript-ui-core/platforms/ios/TNSCore.framework/TNSCore (i386)

" UserInfo={NSLocalizedDescription=Failed to verify bitcode in TNSCore.framework/TNSCore:
error: Cannot extract bundle from /var/folders/qn/rgqwl65s4xzcvkm3_zfc31c80000gn/T/XcodeDistPipeline.bH9/Root/Payload/evalmobile.app/app/tns_modules/nativescript-ui-listview/node_modules/nativescript-ui-core/platforms/ios/TNSCore.framework/TNSCore (i386)

}
error: exportArchive: Failed to verify bitcode in TNSCore.framework/TNSCore:
error: Cannot extract bundle from /var/folders/qn/rgqwl65s4xzcvkm3_zfc31c80000gn/T/XcodeDistPipeline.bH9/Root/Payload/evalmobile.app/app/tns_modules/nativescript-ui-listview/node_modules/nativescript-ui-core/platforms/ios/TNSCore.framework/TNSCore (i386)



Error Domain=IDEFoundationErrorDomain Code=1 "Failed to verify bitcode in TNSCore.framework/TNSCore:
error: Cannot extract bundle from /var/folders/qn/rgqwl65s4xzcvkm3_zfc31c80000gn/T/XcodeDistPipeline.bH9/Root/Payload/evalmobile.app/app/tns_modules/nativescript-ui-listview/node_modules/nativescript-ui-core/platforms/ios/TNSCore.framework/TNSCore (i386)

" UserInfo={NSLocalizedDescription=Failed to verify bitcode in TNSCore.framework/TNSCore:
error: Cannot extract bundle from /var/folders/qn/rgqwl65s4xzcvkm3_zfc31c80000gn/T/XcodeDistPipeline.bH9/Root/Payload/evalmobile.app/app/tns_modules/nativescript-ui-listview/node_modules/nativescript-ui-core/platforms/ios/TNSCore.framework/TNSCore (i386)

}

** EXPORT FAILED **

Unable to apply changes on device: cc570d6ef97bc2ced760463db5bea4cf759801ae. Error is: Command xcodebuild failed with exit code 70.

I'm looking into the rest of the logs currently during an xcode build to see if the ui package is prepped twice.

Here are my deps:

  "dependencies": {
    "@angular/animations": "5.2.6",
    "@angular/cdk": "^5.2.1",
    "@angular/common": "5.2.6",
    "@angular/compiler": "5.2.6",
    "@angular/core": "5.2.6",
    "@angular/forms": "5.2.6",
    "@angular/http": "^5.2.7",
    "@angular/material": "^5.2.1",
    "@angular/platform-browser": "5.2.6",
    "@angular/platform-browser-dynamic": "5.2.6",
    "@angular/router": "5.2.6",
    "core-js": "^2.4.1",
    "rxjs": "^5.5.6",
    "@nrwl/nx": "0.8.0",
    "@ngx-translate/core": "~9.0.2",
    "@ngrx/effects": "5.1.0",
    "@ngrx/router-store": "5.0.1",
    "@ngrx/store": "5.1.0",
    "@ngrx/store-devtools": "5.1.0",
    "email-validator": "^1.1.1",
    "kinvey-nativescript-sdk": "~3.10.0",
    "nativescript-angular": "~5.2.0",
    "nativescript-barcodescanner": "~2.7.5",
    "nativescript-carousel": "~3.1.1",
    "nativescript-drop-down": "~3.2.3",
    "nativescript-exoplayer": "~3.4.1",
    "nativescript-fresco": "~3.0.6",
    "nativescript-snackbar": "~2.0.1",
    "nativescript-loading-indicator": "~2.4.0",
    "nativescript-localstorage": "~1.1.5",
    "nativescript-ngx-fonticon": "~4.0.0",
    "nativescript-permissions": "~1.2.3",
    "nativescript-social-share": "~1.5.0",
    "nativescript-theme-core": "~1.0.4",
    "nativescript-ui-listview": "~3.5.1",
    "nativescript-ui-sidedrawer": "~3.5.1",
    "ngx-progressbar": "^2.1.1",
    "primeng": "^5.2.0",
    "reflect-metadata": "^0.1.12",
    "tns-core-modules": "^3.4.1",
    "ts-md5": "^1.2.4",
    "zone.js": "^0.8.19"
  },

The two ui packages being listview and sidedrawer.

I have not done a release build. I have had someone ping me privately saying they cannot run the application as the xcode build errors out with the above exception. However, when I ran it, it failed but then immediately built again and installed and the app runs fine.

[tgpetrov]

From @bradmartin on March 20, 2018 22:26

After looking at the logs from tns run ios --syncAllFiles
it does prep the ui package twice.

Executing before-prepareJSApp hook from /Users/bradmartin/Desktop/EvalApp/maxmobility/apps/eval-mobile/hooks/before-prepareJSApp/nativescript-dev-webpack.js
Successfully prepared plugin kinvey-nativescript-sdk for ios.
Successfully prepared plugin nativescript-angular for ios.
Successfully prepared plugin nativescript-barcodescanner for ios.
Successfully prepared plugin nativescript-carousel for ios.
Successfully prepared plugin nativescript-drop-down for ios.
Successfully prepared plugin nativescript-exoplayer for ios.
Successfully prepared plugin nativescript-fresco for ios.
Successfully prepared plugin nativescript-loading-indicator for ios.
Successfully prepared plugin nativescript-localstorage for ios.
Successfully prepared plugin nativescript-ngx-fonticon for ios.
Successfully prepared plugin nativescript-snackbar for ios.
Successfully prepared plugin nativescript-theme-core for ios.
Successfully prepared plugin nativescript-ui-listview for ios.
Successfully prepared plugin nativescript-ui-sidedrawer for ios.
Successfully prepared plugin tns-core-modules for ios.
Successfully prepared plugin nativescript-sqlite for ios.
Successfully prepared plugin nativescript-intl for ios.
Successfully prepared plugin nativescript-ui-core for ios.
Successfully prepared plugin nativescript-ui-core for ios.
Successfully prepared plugin tns-core-modules-widgets for ios.
Installing pods...
Analyzing dependencies

My versions:

Brads-MBP:maxmobility bradmartin$ npm -v
5.5.1
Brads-MBP:maxmobility bradmartin$ node -v
v8.9.1
nativescript   : 3.4.0  

Going to try updating the cli and see if it continues as well.

[tgpetrov]

From @radeva on March 21, 2018 5:2

@bradmartin From the log above I can see that there is a node_modules folder in the installed listview package. This is the reason for having issues with multiple core modules in ios. This is not expected and what I'm trying to understand what is causing it - is it some combination of versions or the package-lock.json or anything else. Could you send us some project where this is reproducible (you can use slack or mail)?

[tgpetrov]

From @radeva on March 21, 2018 8:6

@NathanWalker @bradmartin Could you try the following:

• clean your npm cache,
• remove node_modules
• remove package-lock.json
• run npm i

Check if there is node_modules folder in nativescript-ui-listview and nativescript-ui-sidedrawer.

@bradmartin There are a lot of fixes in 5.6.0 so I would recommend to upgrade to 5.6.0 or later: https://github.com/npm/npm/releases/tag/v5.6.0 .

[tgpetrov]

From @NathanWalker on March 26, 2018 20:41

@radeva I'm hoping to have a repo together for you to see this week 👍 thanks for the attention.

[tgpetrov]

From @NathanWalker on March 27, 2018 0:17

Ok @radeva here is a project you can use to repro this issue:
https://github.com/NathanWalker/ui-core-issue

See README

[tgpetrov]

From @radeva on March 27, 2018 14:16

Hi @NathanWalker,

When calling npm run clean this cleans node_modules, hooks, etc.. from the root and installs the dependencies from the package.json on the root level. This installs nativescript-ui-listview and nativescript-ui-sidedrawer. You can see at this stage that there is no node_modules folder in nativescript-ui-sidedrawer and nativescript-ui-listview.

When calling npm run clean.mobile you install the dependencies defined in apps/nativescript-app/package.json which refer to the local folder - the node_modules folder on the root level. With npm5 this creates a symlink and installs the dependencies of the of the dependencies. See npm install <folder> in https://docs.npmjs.com/cli/install . That's how the node_modules folder appears in the nativescript-ui-listview and nativescript-ui-sidedrawer installed packages which causes the errors that you experience.

Your suggestion probably will solve the problem in your setup, but for all other developers out there using the plugins it will require the additional step to install the core package explicitly. So, I'm curious to know what's the reason behind referring your dependencies from a local folder and not from npm?

[tgpetrov]

From @bradmartin on March 27, 2018 14:28

@radeva - I believe the reasoning is the concept behind Nx Workspaces (https://nrwl.io/nx/guide-nx-workspace#create-a-new-nx-workspace). I'll let Nathan confirm that but I think that's why the packages are local and not npm all the time.