Skip to content

chore: ng v8 new loadChildren import syntax #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

manoldonev
Copy link
Contributor

@manoldonev manoldonev commented Sep 11, 2019

PR Checklist

What is the current behavior?

NS Angular templates use loadChildren string syntax in lazy loaded routes.

What is the new behavior?

Angular version 8 deprecated the string syntax in favor of dynamic import. Full details @ https://angular.io/guide/deprecations#loadchildren-string-syntax

Old:

loadChildren: './lazy/lazy.module#LazyModule'

New:

 loadChildren: () => import('./lazy/lazy.module').then(m => m.LazyModule)

@manoldonev manoldonev self-assigned this Sep 11, 2019
@cla-bot cla-bot bot added the cla: yes label Sep 11, 2019
@manoldonev manoldonev merged commit 5817fbf into release Sep 11, 2019
@manoldonev manoldonev deleted the mdonev/loadChildren branch September 11, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants