Skip to content

add info about running the demo #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

tgpetrov
Copy link
Contributor

@tgpetrov tgpetrov commented Jun 6, 2019

  • I added information with steps to run the demo, while now they seem obvious to me, the first time I tried using CodePush there were not so easy to guess.
  • adding an app seems to currently require specifying nativescript so I added it to the docs as well, not sure if the documentation is wrong or it is a bug that the documented script does not work
  • minor change in a column alignment

@EddyVerbruggen EddyVerbruggen added this to the 2.1.0 milestone Jun 6, 2019
@EddyVerbruggen EddyVerbruggen self-assigned this Jun 6, 2019
@EddyVerbruggen
Copy link
Contributor

Hey Todor, thanks a million for these changes. Very helpful!

I have every intention to remove the need to specify nativescript, so I'm happy you flagged these issues and I'll look at the CLI to figure out where I forgot to change the implementation.

@EddyVerbruggen EddyVerbruggen merged commit 4564d72 into NativeScript:master Jun 6, 2019
EddyVerbruggen added a commit that referenced this pull request Jun 6, 2019
@EddyVerbruggen
Copy link
Contributor

I've just released nativescript-code-push-cli version 1.0.6 which fixes the mandatory nativescript param. That'll no longer be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants