Migrate from ReflectiveInjector (deprecated) to StaticInjector #1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladimirAmiorkov
approved these changes
Jun 21, 2019
|
test |
|
test |
VladimirAmiorkov
pushed a commit
that referenced
this pull request
Jun 28, 2019
* chore: bump version * Update zone.js peer dependency * update zone.js in all apps * Make repo apps compatible with `--bundle` (#1857) * chore: upgrade app to latest versions and webpack * chore: fix incorrect temlateUrl in component chore: update karma config for latest CLI beta 6.0.0 * chore: make `router-tab-view` example webpack compatible * chore: make `nested-router-tab-view` example webpack compatible * chore: fix lazy loaded component not loading * chore: make `modal-navigation-ng` example webpack compatible * chore: add webpack config due to issue in CLI that disregards the `nsconfig.json` * chore: update test app with latest deps and remove not used d.ts * chore: update karma config * chore: resolve issue caused by overrding `global.__extends ` * chore: update Angular deps * chore: update `nativescript-dev-webpack` to next * refactor: unit-test configs * test: update webpack config * refactor: remove deprecated API usage (#1874) * tests: mocha reporter and include ts files (#1875) * Migrate from ReflectiveInjector (deprecated) to StaticInjector (#1868) * chore: migrate to StaticInjector * chore: replace parentInjector in detached-loader * release: cut the 8.0.2 release * chore: update version * chore: update CHANGELOG for 8.0.2
zbranzov
pushed a commit
that referenced
this pull request
Jul 5, 2019
* chore: bump version * Update zone.js peer dependency * update zone.js in all apps * Make repo apps compatible with `--bundle` (#1857) * chore: upgrade app to latest versions and webpack * chore: fix incorrect temlateUrl in component chore: update karma config for latest CLI beta 6.0.0 * chore: make `router-tab-view` example webpack compatible * chore: make `nested-router-tab-view` example webpack compatible * chore: fix lazy loaded component not loading * chore: make `modal-navigation-ng` example webpack compatible * chore: add webpack config due to issue in CLI that disregards the `nsconfig.json` * chore: update test app with latest deps and remove not used d.ts * chore: update karma config * chore: resolve issue caused by overrding `global.__extends ` * chore: update Angular deps * chore: update `nativescript-dev-webpack` to next * refactor: unit-test configs * test: update webpack config * refactor: remove deprecated API usage (#1874) * tests: mocha reporter and include ts files (#1875) * Migrate from ReflectiveInjector (deprecated) to StaticInjector (#1868) * chore: migrate to StaticInjector * chore: replace parentInjector in detached-loader * feat(tabs): register tabs elements (#1883) * feat(tabs): register tabs elements * feat(tests-app-ng): add tabs component * chore: fix android28 animation tests (#1885) * chore: retry a flaky test on failure (#1886) * release: cut the 8.0.2 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Failing tests are not related to this change (convert string to dates). For some reason the demo app was failing to launch for me with "Application already started"
What is the current behavior?
ReflectiveInjector is being used to create components. This was deprecated in Angular 5 for being slow.
parentInjectoris also deprecated (angular/angular#25174), so it has been replaced byinjectorWhat is the new behavior?
Use StaticInjector and
injectorto create the modal components.Possibly related to #1719