Skip to content

fix: remove child from previous parent if needed due to animations #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022
Merged

fix: remove child from previous parent if needed due to animations #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/angular/src/lib/view-util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ export class ViewUtil {
const extendedParent = this.ensureNgViewExtensions(parent);
const extendedChild = this.ensureNgViewExtensions(child);

// this should never enter, as angular is supposed to remove the child from the previous parent before calling this
// but when angular animations are enabled, the removal might be delayed, so we need to ensure this view is not anywhere
// this seems to only happens to CommentNodes
if (extendedChild.parentNode) {
this.removeChild(extendedChild.parentNode, extendedChild);
}
// if there's a next child, previous is the previousSibling of it
if (next) {
previous = next.previousSibling;
Expand Down