Skip to content

fix: skip ChildrenOutLetContexts destroy hook if outlet has been changed #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2021
Merged

fix: skip ChildrenOutLetContexts destroy hook if outlet has been changed #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
328d9ac
fix: skip ChildrenOutLetContexts destroy hook if outlet has been changed
Oct 7, 2021
f68a5c6
fix: handle case where `getContext()` is null
Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/angular/src/lib/legacy/router/page-router-outlet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,14 @@ export class PageRouterOutlet implements OnDestroy {
}

ngOnDestroy(): void {
// Clear accumulated modal view page cache when page-router-outlet
// destroyed on modal view closing
this.parentContexts.onChildOutletDestroyed(this.name);
// In the event that the `parentContexts` has changed the outlet
// via the creation of another outlet, the `onChildOutletDestroyed`
// will be skipped
if (this.parentContexts.getContext(this.name)?.outlet === <any>this) {
// Clear accumulated modal view page cache when page-router-outlet
// destroyed on modal view closing
this.parentContexts.onChildOutletDestroyed(this.name);
}

if (this.outlet) {
this.outlet.outletKeys.forEach((key) => {
Expand Down