Skip to content

(GitHub Toggle Issue Comments) In some issue pages, there's an unneeded "1 hidden (from hidden comments)" when 'GitHub Sort Reactions' is also installed #57

Closed
@darkred

Description

@darkred

Hi again dear @Mottie

Unfortunately I just found another issue:
in some issue pages I tried,
when both "GitHub Toggle Issue Comments" and "GitHub Sort Reactions" are installed,
there's a unneeded 1 hidden (from hidden comments) under the first post

STR

  • with a fresh Chrome browser profile with only TM 4.8.5850 beta and scripts GTIC 1.23 and GSR 0.2.6
  • open either
    https://github.com/Microsoft/vscode/issues/58712 or https://github.com/Microsoft/vscode/issues/59142
  • make sure that only the "+1 Comments" filter in GTIC is active:
    notice that in both URLs, when you click it, it becomes "+1 Comments (1 hidden)".
    but there's no comment actually hidden (there's no "+1" comment to hide)
  • notice that there's a 1 hidden (from hidden comments) under the first post.
  • If you disable GSR, then the issue no longer occurs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions