Skip to content

Fix bug introduced in 0.19 related to DictField validation #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2020

Conversation

bagerard
Copy link
Collaborator

Fixes #2239

I havn't found an easy way to get the mongodb version associated with the database (associated with the Document class) from the DictField and I don't think it's a good idea to try to do so.
So I've only kept the validation rule for the latest mongo (valif >=3.6)

@bagerard bagerard requested a review from erdenezul January 11, 2020 22:28
@bagerard
Copy link
Collaborator Author

bagerard commented Jan 11, 2020

I'll trigger 0.19.2 after this is merged since it could be blocking
Since it doesn't seem to impact a lot of people, it will wait 0.20

@bagerard bagerard force-pushed the fix_dictfield_validation branch from a011c3f to ad0669a Compare March 17, 2020 09:15
@bagerard bagerard merged commit 00ae629 into MongoEngine:master Mar 17, 2020
@bagerard bagerard deleted the fix_dictfield_validation branch March 17, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DictField validate failed without default connection
2 participants