This repository was archived by the owner on Jul 13, 2020. It is now read-only.
Fix for error handling in latest version of traceur #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detected during compilation. The module loader would just report the first. In 0.9.3 though, Tracuer was updated to instead throw a single "MultipleErrors" type that contained all the errors inside it. The module loader currently just reports "undefined" as the error, as there is no array with elements, making for a rather opaque error when a compilation error occurs. This modifies it to still throw the first element when dealing with an array for backwards compatibility, but will otherwise throw the full exception.
guybedford
added a commit
that referenced
this pull request
Dec 27, 2015
Fix for error handling in latest version of traceur
|
Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Traceur would return an array of errors when several were detected during compilation. The module loader would just report the first. In 0.9.3 though, Tracuer was updated to instead throw a single MultipleErrors type that contains all the errors inside it.
The module loader currently just reports "undefined" as the error, as there is no array with elements, making for a rather opaque error when a compilation error occurs.
This modifies it to still throw the first element when dealing with an array for backwards compatibility, but will otherwise throw the full exception.