This repository was archived by the owner on Jul 13, 2020. It is now read-only.
Track whether transpiler has ran with a flag on the Loader #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,12 +15,12 @@ | |||
| var self = this; | |||
|
|
|||
| // pick up Transpiler modules from existing globals on first run if set | |||
| if (firstRun) { | |||
| if (!self.transpilerHasRan) { | |||
|
Sure that works great for me. |
This fixes a bug where setting Traceur and/or Babel wasn't happening in multiple-loader scenarios. Instead of using a closure variable set one on the loader itself. Picked a long name to avoid collision. Fixes ModuleLoader#347
matthewp
force-pushed
the
check-transpiler-ran
branch
from
780c316 to
680e90a
Compare
|
Ok, updated. |
guybedford
added a commit
that referenced
this pull request
Apr 4, 2015
Track whether transpiler has ran with a flag on the Loader
|
Would you like a release now as well? |
|
It's not needed, thanks though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where setting Traceur and/or Babel wasn't happening in
multiple-loader scenarios. Instead of using a closure variable set one
on the loader itself.
Picked a long name to avoid collision. Fixes #347