This repository was archived by the owner on Jul 13, 2020. It is now read-only.
Make exact matches win for path lookup #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where when a wildcard path is specified *after* an exact path the wildcard would win. The reason is that for/in loops go in the order that the keys were defined. Deleting the key and readding it shows the error. The fix is simply to break out the loop once we find an exact match. Fixes ModuleLoader#189
|
This is great, thanks! |
guybedford
added a commit
that referenced
this pull request
Jul 24, 2014
Make exact matches win for path lookup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where when a wildcard path is specified after an exact path the wildcard would win. The reason is that for/in loops go in the order that the keys were defined. Deleting the key and re-adding it shows the error. The fix is simply to break out the loop once we find an exact match. Fixes #189