Skip to content
This repository was archived by the owner on Jul 13, 2020. It is now read-only.

Don't create a Module if the evaluation fails. #188

Merged
merged 1 commit into from
Jul 21, 2014
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,8 @@ function logloads(loads) {
err = doExecute(module);
if (err)
module.failed = true;
module.module = _newModule(module.exports);
else
module.module = _newModule(module.exports);
module.execute = undefined;
return err;
}
Expand Down Expand Up @@ -968,7 +969,7 @@ function logloads(loads) {
// 26.3.3.14
set: function(name, module) {
if (!(module instanceof Module))
throw new TypeError('Set must be a module');
throw new TypeError('Loader.set(' + name + ', module) must be a module');
this._loader.modules[name] = {
module: module
};
Expand Down