Skip to content
This repository was archived by the owner on Jul 13, 2020. It is now read-only.

Fix baseURL documentation in README.md #187

Merged
merged 1 commit into from
Jul 21, 2014
Merged

Fix baseURL documentation in README.md #187

merged 1 commit into from
Jul 21, 2014

Conversation

jansauer
Copy link
Contributor

As far as I can see the baseURL is trimmed until the last index of /. So in order to achieve the load from /js/lib/module.js there is a trailing slash needed.

I have only tested it in the browser.

As far as I can see the `baseURL` is trimmed until the last index of `/`. So in order to achieve the load from `/js/lib/module.js` there is a trailing slash needed.

I have only tested it in the browser.
@guybedford
Copy link
Member

Thanks - yes you are right, this is because baseURL is used to do normalizations with toAbsoluteURL(baseURL, url), so we need the trailing slash.

guybedford added a commit that referenced this pull request Jul 21, 2014
Fix baseURL documentation in README.md
@guybedford guybedford merged commit bc590de into ModuleLoader:master Jul 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants