This repository was archived by the owner on Jul 13, 2020. It is now read-only.
Refactor loader.js to isolate compiler in function parse(load). #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Was the plan to make this a public function eventually? Are the tests passing in the browser ok? |
|
Yes, as hook function. I'll have to figure out how to run the tests in browser. |
|
|
|
Shall I go ahead with the merge here? |
|
I just finished the API work on traceur so I can rebase and retest soon. |
Function parse(load) returns array of ModuleSpecifer strings
|
Rebase and test in browser 51/52 pass, |
guybedford
added a commit
that referenced
this pull request
Jun 22, 2014
Refactor loader.js to isolate compiler in function parse(load).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function parse(load) returns array of ModuleSpecifer strings