-
Notifications
You must be signed in to change notification settings - Fork 967
Update C2860 #4987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update C2860 #4987
Conversation
@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 114092d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
--- | ||
# Compiler Error C2860 | ||
|
||
'void' cannot be an argument type, except for '(void)' | ||
'void' cannot be used as a function parameter except for '(void)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we prefer using block quotes for the error message, like:
- 'void' cannot be used as a function parameter except for '(void)'
+ > 'void' cannot be used as a function parameter except for '(void)'
How about the usage of Remarks
and Example
subheaders?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'typical' style for these, for no good reason that I know of other than that's what the rest use, is to avoid block quotes and to not add the ## Example or ## Remarks sections. There are some exceptions if you look around, but they are more the exception than the rule. So we may as well stay with the format most of them are in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Definitely an improvement.
#sign-off |
Updated the error message (changed since VS2022 17.2 (19.32)):
Also tweaked the example.