Skip to content

Update C2860 #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Update C2860 #4987

merged 1 commit into from
Mar 18, 2024

Conversation

Rageking8
Copy link
Contributor

Updated the error message (changed since VS2022 17.2 (19.32)):

- 'void' cannot be an argument type, except for '(void)'
+ 'void' cannot be used as a function parameter except for '(void)'

Also tweaked the example.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 114092d:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-errors-2/compiler-error-c2860.md ✅Succeeded
docs/error-messages/compiler-errors-2/compiler-errors-c2800-through-c2899.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

---
# Compiler Error C2860

'void' cannot be an argument type, except for '(void)'
'void' cannot be used as a function parameter except for '(void)'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we prefer using block quotes for the error message, like:

- 'void' cannot be used as a function parameter except for '(void)'
+ > 'void' cannot be used as a function parameter except for '(void)'

How about the usage of Remarks and Example subheaders?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'typical' style for these, for no good reason that I know of other than that's what the rest use, is to avoid block quotes and to not add the ## Example or ## Remarks sections. There are some exceptions if you look around, but they are more the exception than the rule. So we may as well stay with the format most of them are in.

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Definitely an improvement.

@TylerMSFT
Copy link
Collaborator

#sign-off

@ShannonLeavitt ShannonLeavitt merged commit 378c6de into MicrosoftDocs:main Mar 18, 2024
@Rageking8 Rageking8 deleted the update-c2860 branch March 20, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants