Skip to content

Tighten wording in mutable data members #4984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Rageking8
Copy link
Contributor

Add missing "non-reference" constraint, since mutable is not allowed on reference data members. The empty main function is removed as it does not serve any purpose.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 3ba42ac:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/cpp/mutable-data-members-cpp.md ⚠️Warning Details

docs/cpp/mutable-data-members-cpp.md

  • Line 4, Column 10: [Warning: ms-date-invalid - See documentation] Value out of range for 'ms.date': '03/14/2024'. If specified, must be a date in format M/D/YYYY, no later than today. If you don't specify ms.date, the date will be updated automatically.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Rageking8
Copy link
Contributor Author

It is already 14 march in my timezone.

@TylerMSFT
Copy link
Collaborator

It is already 14 march in my timezone.

The system only cares about its timezone. We can either wait a day or back the date up 1 day.

@Rageking8
Copy link
Contributor Author

I don't mind waiting till tomorrow. Will take note of the date in the future.

@Jak-MS
Copy link
Contributor

Jak-MS commented Mar 13, 2024

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Mar 13, 2024
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
#signoff

@TylerMSFT
Copy link
Collaborator

#sign-off

@ShannonLeavitt ShannonLeavitt merged commit 8202709 into MicrosoftDocs:main Mar 15, 2024
@Rageking8 Rageking8 deleted the tighten-wording-in-mutable-data-members branch March 16, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants