Skip to content

Improve C4834 spacing, line wrapping, and wording #4644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2023
Merged

Improve C4834 spacing, line wrapping, and wording #4644

merged 2 commits into from
Jul 21, 2023

Conversation

cgettys-microsoft
Copy link
Contributor

@cgettys-microsoft cgettys-microsoft commented Jul 21, 2023 •
edited
Loading

My previous PR #4638 added an unintended space in line 48.
While I'm at it:

  • Improve consistency of wording added in my previous PR and the rest of the article.
  • Improve line breaks in example and restructure it for legibility

@cgettys-microsoft
Fix Unintentional spacing, improve wording
ef46ccc 
My first PR added an unintended space in line 46. also improve wording
@prmerger-automator
Copy link
Contributor

@cgettys-microsoft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator prmerger-automator bot requested a review from TylerMSFT July 21, 2023 19:30
@cgettys-microsoft
Copy link
Contributor Author

cgettys-microsoft commented Jul 21, 2023 •
edited
Loading

Ready for #sign-off from my side assuming the build succeeds.

@prmerger-automator
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @TylerMSFT

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit ef46ccc:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-warnings/c4834.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@cgettys-microsoft
Copy link
Contributor Author

cgettys-microsoft commented Jul 21, 2023 •
edited
Loading

Apologies, actually ready for #sign-off now - I realized that my edits to the example made it require significant horizontal scrolling due to long comments, and decided to fix that too.

@prmerger-automator
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @TylerMSFT

1 similar comment
@prmerger-automator
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @TylerMSFT

@cgettys-microsoft cgettys-microsoft changed the title Remove extra space and improve wording in C4834 Improve C4834 spacing, line wrapping, and wording Jul 21, 2023
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 6884fd3:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-warnings/c4834.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@TylerMSFT
Copy link
Collaborator

#sign-off

@Jak-MS Jak-MS merged commit 02e7ec1 into MicrosoftDocs:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerMSFT TylerMSFT TylerMSFT approved these changes

Assignees

@TylerMSFT TylerMSFT

Labels
Change sent to author cpp-diagnostics/tech needs-human-review ready-to-merge visual-cpp/prod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgettys-microsoft @TylerMSFT @Jak-MS