-
Notifications
You must be signed in to change notification settings - Fork 966
fopen-wfopen.md: initial comma for ccs= option #4234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unlike the other mode options, `ccs=` must always be prefixed with a comma. The examples made this clear, but the table and text didn't. I think that point is made more obvious if one always writes `,ccs=`
@skissane : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 3b51ee0: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #label:"aq-pr-triaged" |
Hi @skissane, |
@TylerMSFT I take your point point about the comma not actually being part of the flag. I do still think there is an issue here though. Only (1) is standardised as part of the ISO C standard, although the C99 rationale document (see section 7.19.5.3, page numbered 150, PDF page 157) gives an example of (2) as a possible extension. For Windows UCRT, Anyway, my point is, the documentation text never clearly explains that Maybe my proposed change was not the best way of communicating this, but I do think the documentation would be more understandable if this fact was made explicit, somehow. |
@skissane , I addressed your point by adding the following to the css entry in the table: This flag is separated from flags that precede it by a comma ( |
Unlike the other mode options,
ccs=
must always be prefixed with a comma. The examples made this clear, but the table and text didn't. I think that point is made more obvious if one always writes,ccs=