Skip to content

Add left-out nullptr for example code in SetValue #4218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2022

Conversation

rtischer8277
Copy link
Contributor

As suggested, SetValue's example code should be checked against nullptr: if( property ) needs to be if( property != nullptr )

As suggested, SetValue's example code should be checked against nullptr: if( property ) needs to be if( property != nullptr )
@opbld32
Copy link

opbld32 commented Oct 13, 2022

Learn Build status updates of commit 5d1363e:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cmfcpropertygridproperty-class.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Oct 13, 2022

@corob-msft

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Oct 13, 2022
@Court72
Copy link
Contributor

Court72 commented Oct 13, 2022

Trying a close/reopen to clear the stuck license/cla check.

@opbld33
Copy link

opbld33 commented Oct 13, 2022

Learn Build status updates of commit 5d1363e:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cmfcpropertygridproperty-class.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Oct 13, 2022

Trying another close/reopen to clear the stuck license/cla check.

@opbld30
Copy link

opbld30 commented Oct 13, 2022

Learn Build status updates of commit 5d1363e:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cmfcpropertygridproperty-class.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@v-lmcdonald
Copy link

Trying another close/reopen to clear the stuck license/cla check.

@opbld31
Copy link

opbld31 commented Oct 13, 2022

Learn Build status updates of commit 5d1363e:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cmfcpropertygridproperty-class.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@colin-home colin-home closed this Oct 14, 2022
@colin-home colin-home reopened this Oct 14, 2022
@opbld31
Copy link

opbld31 commented Oct 14, 2022

Learn Build status updates of commit 5d1363e:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cmfcpropertygridproperty-class.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@rtischer8277 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@opbld31
Copy link

opbld31 commented Oct 14, 2022

Learn Build status updates of commit 5d1363e:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cmfcpropertygridproperty-class.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32
Copy link

opbld32 commented Oct 14, 2022

Learn Build status updates of commit f4e96df:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit f4e96dff2b6fcdffa75e174dfab3ac9a130652ff in branch patch-3 of repository https://github.com/rtischer8277/cpp-docs into branch main (commit dc882505c7b93bfa2292568281648f6befa4b593). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@colin-home
Copy link
Contributor

Yeah, this will take some work. Sit tight.

@colin-home
Copy link
Contributor

I'm going to wait on the next merge from the private branch before going any further.

@colin-home colin-home closed this Oct 15, 2022
@colin-home colin-home reopened this Oct 15, 2022
@opbld30
Copy link

opbld30 commented Oct 15, 2022

Learn Build status updates of commit f4e96df:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit f4e96dff2b6fcdffa75e174dfab3ac9a130652ff in branch patch-3 of repository https://github.com/rtischer8277/cpp-docs into branch main (commit dc882505c7b93bfa2292568281648f6befa4b593). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld32
Copy link

opbld32 commented Oct 15, 2022

Learn Build status updates of commit 07e9c20:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cmfcpropertygridproperty-class.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@colin-home colin-home merged commit 9f9fff2 into MicrosoftDocs:main Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants