-
Notifications
You must be signed in to change notification settings - Fork 967
Use the correct canonical opcode name in the packed unwind table #4214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Learn Build status updates of commit 00e4d66: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@mstorsjo : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, great, thanks! Yeah a shorter name would be convenient. Although, I had just landed a change in LLVM making this name used in an external assembly directive name, in llvm/llvm-project@c43bff6. But since it literally landed a couple hours ago (and we're months away from a release), it's shouldn't be a problem to switch it over there to a less unwieldy name (and that's certainly appreciated). |
00e4d66
to
d8d2f48
Compare
Learn Build status updates of commit d8d2f48: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
This was a leftover from the original tentative name before the real one was known.
d8d2f48
to
c35142d
Compare
Learn Build status updates of commit c35142d: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@mstorsjo : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Looks good to me. Thanks. |
This was a leftover from the original tentative name before the real one was known.
Sorry for missing this...