Skip to content

Use the correct canonical opcode name in the packed unwind table #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

mstorsjo
Copy link
Contributor

This was a leftover from the original tentative name before the real one was known.

Sorry for missing this...

@opbld32
Copy link

opbld32 commented Oct 12, 2022

Learn Build status updates of commit 00e4d66:

✅ Validation status: passed

File Status Preview URL Details
docs/build/arm64-exception-handling.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@mstorsjo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mstorsjo
Since the name is arbitrary, @pmsjt (whose fingerprints are on the Windows ARM64 unwind code) convinced me to shorten it to pac_sign_lr instead. I couldn't find any evidence the longer name is exposed anywhere except in a tool internal to Microsoft.

@mstorsjo
Copy link
Contributor Author

Since the name is arbitrary, @pmsjt (whose fingerprints are on the Windows ARM64 unwind code) convinced me to shorten it to pac_sign_lr instead. I couldn't find any evidence the longer name is exposed anywhere except in a tool internal to Microsoft.

Ok, great, thanks! Yeah a shorter name would be convenient.

Although, I had just landed a change in LLVM making this name used in an external assembly directive name, in llvm/llvm-project@c43bff6. But since it literally landed a couple hours ago (and we're months away from a release), it's shouldn't be a problem to switch it over there to a less unwieldy name (and that's certainly appreciated).

@opbld32
Copy link

opbld32 commented Oct 12, 2022

Learn Build status updates of commit d8d2f48:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit d8d2f48dbc25c0ec439caaba410ab99e172fc0d6 in branch arm64-unwind-pac of repository https://github.com/mstorsjo/cpp-docs into branch main (commit 0bd04f6188cfd922d34759a039470a23404bac15). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

This was a leftover from the original tentative name before the
real one was known.
@opbld30
Copy link

opbld30 commented Oct 12, 2022

Learn Build status updates of commit c35142d:

✅ Validation status: passed

File Status Preview URL Details
docs/build/arm64-exception-handling.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@mstorsjo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@pmsjt
Copy link
Contributor

pmsjt commented Oct 12, 2022

Looks good to me. Thanks.

@colin-home colin-home merged commit cc995af into MicrosoftDocs:main Oct 12, 2022
@mstorsjo mstorsjo deleted the arm64-unwind-pac branch October 13, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants