Library can't be instrumented with JaCoCo

[Hi-Fi]

Our application's test coverage for Robot Framework tests is measured with JaCoCo. When using Selenium2Library-java in run (as Maven dependency), getting errors about failing instrumentation.

E.g.

java.lang.instrument.IllegalClassFormatException: Error while instrumenting class com/github/markusbernhardt/selenium2library/keywords/Selenium2LibraryEnhancement.
Caused by: java.lang.IllegalStateException: Missing or invalid stackmap frames.
java.lang.instrument.IllegalClassFormatException: Error while instrumenting class com/github/markusbernhardt/selenium2library/keywords/Waiting.
Caused by: java.lang.IllegalStateException: Missing or invalid stackmap frames.
java.lang.instrument.IllegalClassFormatException: Error while instrumenting class com/github/markusbernhardt/selenium2library/keywords/TableElement.
Caused by: java.lang.IllegalStateException: Missing or invalid stackmap frames.

etc.

Full stack traces available at:
http://pastebin.com/ZPJbHJaf

Workaround for us is just to tell JaCoCo to include application packages, but it might still be good to figure out why instrumentation fails in library.

[MarkusBernhardt]

To make JaCoCo work together with AspectJ we need to

• upgarde AspectJ version >= 1.7
• compile against JDK 1.7

Especially about the upgrade to Java 1.7 I'm not sure, whether we should do that now.

[MarkusBernhardt]

I have updated now AspectJ to 1.7.3.
Could you test, whether JaCoCo works now with JDK 7?

[Hi-Fi]

Still getting same errors.
javac 1.7.0_07
Jacoco 0.6.3.201306030806

Using jacoco agent in MAVEN_OPTS:
MAVEN_OPTS="-javaagent:C:\work\jacoco\lib\jacocoagent.jar"

Tests itself will pass even JaCoCo throws those errors.

[MarkusBernhardt]

Could you please change <java.version>1.7</java.version> in the pom.xml, build the library and use that version.

[Hi-Fi]

That helped, after I added the source version also to aspectJ plugin's configuration.

[MarkusBernhardt]

Could you please post, where you had to add the java version to the aspectj plugin?
I think I will switch my dev tree to 1.7 then.

[Hi-Fi]

Like this:

                <configuration>
                    <source>${java.version}</source>
                    <target>${java.version}</target>
                    <complianceLevel>${java.version}</complianceLevel>
                    <showWeaveInfo>true</showWeaveInfo>
                </configuration>

[MarkusBernhardt]

Checked in. New releases will be for JDK 1.7
Closing