-
Notifications
You must be signed in to change notification settings - Fork 420
Add arm64 mac and linux wheels #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,7 +56,7 @@ jobs: | |
submodules: true | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v2 | ||
uses: actions/setup-python@v4 | ||
|
||
- name: Build source distribution | ||
run: | | ||
|
@@ -68,19 +68,35 @@ jobs: | |
name: dist | ||
path: dist/*.tar.* | ||
|
||
build-wheels: | ||
build-wheels-matrix: | ||
needs: validate-release-request | ||
runs-on: ubuntu-latest | ||
outputs: | ||
include: ${{ steps.set-matrix.outputs.include }} | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-python@v4 | ||
- run: pip install cibuildwheel==2.10.2 | ||
- id: set-matrix | ||
run: | | ||
MATRIX_INCLUDE=$( | ||
{ | ||
cibuildwheel --print-build-identifiers --platform linux --arch x86_64,aarch64 | grep cp | jq -Rc '{"only": inputs, "os": "ubuntu-latest"}' \ | ||
&& cibuildwheel --print-build-identifiers --platform macos --arch x86_64,arm64 | grep cp | jq -Rc '{"only": inputs, "os": "macos-latest"}' \ | ||
&& cibuildwheel --print-build-identifiers --platform windows --arch x86,AMD64 | grep cp | jq -Rc '{"only": inputs, "os": "windows-latest"}' | ||
} | jq -sc | ||
) | ||
echo ::set-output name=include::"$MATRIX_INCLUDE" | ||
|
||
build-wheels: | ||
needs: build-wheels-matrix | ||
runs-on: ${{ matrix.os }} | ||
continue-on-error: true | ||
name: Build ${{ matrix.only }} | ||
|
||
strategy: | ||
matrix: | ||
os: [ubuntu-latest, macos-latest, windows-latest] | ||
cibw_python: ["cp36-*", "cp37-*", "cp38-*", "cp39-*", "cp310-*"] | ||
cibw_arch: ["auto64", "auto32"] | ||
exclude: | ||
- os: macos-latest | ||
cibw_arch: "auto32" | ||
- os: ubuntu-latest | ||
cibw_arch: "auto32" | ||
include: ${{ fromJson(needs.build-wheels-matrix.outputs.include) }} | ||
|
||
defaults: | ||
run: | ||
|
@@ -94,20 +110,26 @@ jobs: | |
with: | ||
fetch-depth: 50 | ||
submodules: true | ||
|
||
- name: Set up QEMU | ||
if: runner.os == 'Linux' | ||
uses: docker/setup-qemu-action@v2 | ||
|
||
- uses: pypa/cibuildwheel@v2.8.0 | ||
- uses: pypa/cibuildwheel@v2.10.2 | ||
with: | ||
only: ${{ matrix.only }} | ||
env: | ||
CIBW_BUILD_VERBOSITY: 1 | ||
CIBW_BUILD: ${{ matrix.cibw_python }} | ||
CIBW_ARCHS: ${{ matrix.cibw_arch }} | ||
CIBW_MANYLINUX_X86_64_IMAGE: manylinux_2_28 | ||
CIBW_MANYLINUX_AARCH64_IMAGE: manylinux_2_28 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could remove these two completely, defaulting to Though on centos, CI also has postgres installation script issues (I started out with it), something about a bad GPG key also mentioned on the developer's 3rd party yum repo's issue tracker. Thought about doing a yum search (or smth) to download the exact URL for the respective postgres versions on the official repo. In the end, I happily accepted gg when I saw the green ticks on CI as it is now. Martin.Obiols.-.Can.t.stop.laughing.at.this.1255206061159714819.mp4There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should try and keep compatibility with 2_21 at least.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah, I think this thread is irrelevant, the current state of this PR (so building on almalinux8) already produces wheels that are backward compatible all the way to 2_17 ref https://github.com/ddelange/asyncpg/actions/runs/3121931647/jobs/5063553875#step:4:950 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @elprans I think in this respect we're good to go 👍 |
||
|
||
- uses: actions/upload-artifact@v2 | ||
with: | ||
name: dist | ||
path: wheelhouse/*.whl | ||
|
||
publish-docs: | ||
needs: validate-release-request | ||
needs: [build-sdist, build-wheels] | ||
runs-on: ubuntu-latest | ||
|
||
env: | ||
|
@@ -121,7 +143,7 @@ jobs: | |
submodules: true | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v2 | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: 3.8 | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.