Add support for the text I/O fallback for arrays of unknown types. #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
force-pushed
the
fix-text-array-fallback
branch
from
29b097c to
0452b8f
Compare
lelit
reviewed
Mar 15, 2017
asyncpg/protocol/codecs/array.pyx
Outdated
| for i in range(elem_len): | ||
| ch = elem_str[i] | ||
| if ch == b'"' or ch == b'\\': | ||
| # Quites and backslashes need escaping. |
elprans
force-pushed
the
fix-text-array-fallback
branch
from
0452b8f to
6780e45
Compare
Currently, asyncpg supports falling back to text I/O for types that do not have a registered codec. This commit extends this behaviour to arrays of such types. Additionally, add an explicit error for when the text I/O is attempted for a range or a composite type, as these are not supported yet. Fixes: #82.
elprans
force-pushed
the
fix-text-array-fallback
branch
from
6780e45 to
c021b3f
Compare
1st1
approved these changes
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, asyncpg supports falling back to text I/O for types that do not have a registered codec. This commit extends this behaviour to arrays of such types.
Additionally, add an explicit error for when the text I/O is attempted for a range or a composite type, as these are not supported yet.