Fix method calls on custom Record subclasses #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation has a bunch of `CheckExact` calls in front of most `Record` methods, effectively making them unusable in subclasses. Relax the check to include the subclasses. While at it, add a check that `__init__` and `__new__` are not redefined on the provided Record subclass. Doing so is pointless, because `Record` instance initialization effectively bypasses both, so raise an `InterfaceError` to avoid needless confusion. Fixes: #676
elprans
force-pushed
the
fix-custom-record
branch
from
9a36cec to
c162909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation has a bunch of
CheckExactcalls in front ofmost
Recordmethods, effectively making them unusable in subclasses.Relax the check to include the subclasses.
While at it, add a check that
__init__and__new__are not redefinedon the provided Record subclass. Doing so is pointless, because
Recordinstance initialization effectively bypasses both, so raise anInterfaceErrorto avoid needless confusion.Fixes: #676