This repository was archived by the owner on Aug 30, 2024. It is now read-only.
MAINT: install gfortran on linux #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* install gfortran in the Docker container used for Linux testing so that f2py tests are not skipped with crytpic messages about missing C compilers
|
Linux test skip counts indeed look drastically smaller now, even in the case of the Pinv failure scenario. |
IIRC, that was when we stopped releasing 32 bit Mac wheels. This looks good to me. Thanks Tyler. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #22, at least for Linux--both 32 and 64-bit Docker containers seem to be missing
gfortranthere. Mac doesn't seem to have this problem at the moment.If this works, all linux tests should adjust from having 500+ skips to a more reasonable number of skips, irrespective of the sporadic failure or 32/64-bit status.
I also find the comment above my changes to be confusing:
Especially since I've been trying to debug the sporadic
Pinvissue again on a private repo with debug / interactive Travis mode. I'll see if I can figure out what changes are associated with that comment. Thecomplex64failure had me thinking aboutm32compile / link flags again as well.Perhaps the comment refers to Mac, but that is confusing given the context is a more general function.