Change in type promotion introduced in Numpy 2.0. Fixes to edf.py. #527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #493, numpy 2.0 introduced changes to type promotion. The change is outlined at: https://numpy.org/devdocs/numpy_2_0_migration_guide.html#changes-to-numpy-data-type-promotion
Running the tests in
weak_and_warn
raises the following warnings:This pull request addresses the issue by setting
temp_all_sigs
andtemp_sig_data
tonp.int64
.For reference,
temp_all_sigs
andtemp_sig_data
are initially set asnp.int64
:wfdb-python/wfdb/io/convert/edf.py
Lines 402 to 404 in c6d4fd9
baseline
is set toint64
here:wfdb-python/wfdb/io/convert/edf.py
Lines 353 to 355 in c6d4fd9