Skip to content

feat: support hex color with # #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2025
Merged

Conversation

seblyng
Copy link
Contributor

@seblyng seblyng commented Apr 29, 2025

I am using neovim, and neovim recently got support for textDocument/documentColor.

I also have a colortheme defined in my config, where I have a bunch of hex colors like #a6e3a2. It would be really nice if this server could support the colors in this format😅

This PR adds support for this, and seems to be working pretty good for me

Before:
image

After:
image

@clason
Copy link

clason commented May 2, 2025

Note: emmyluals already supports this format (but doesn't include the # in the range -- @CppCXY is that something that can be fixed/changed?)

@sumneko sumneko merged commit 759e8fb into LuaLS:master May 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants