Released submodule tarball size increased 12x in latest version

[icp1994]

Hi, the submodule tarball size in previous releases were around 30MB but it's now 371MB. Is this change intentional?

[clason]

Is there a way to include json.lua without (recursively!) pulling in all its submodules for the benchmark? On my machine, that blows up the repo size to 1.5 Gb and takes hours to clone...

[actboy168]

@clason How did you pull the repo? By default it should not recurse to fetch submodules, like this

git submodule init
git submodule update

[sumneko]

@clason How did you pull the repo? By default it should not recurse to fetch submodules, like this

git submodule init
git submodule update

I think it is necessary to fetch submodules recursively, since luamake requires bee.lua

[clason]

Yes, that's what https://github.com/LuaLS/lua-language-server/wiki/Getting-Started#build says we should do.

The only thing I can think of is to specify the submodules individually:

> git submodule update --init --recursive luamake
> git submodule update --init json.lua
> ...

Maybe it's enough to add a simple script update_submodules.sh under 3rd that users can run so that the build instructions become

./3rd/update_submodules.sh
cd 3rd/luamake
./compile/install.sh
cd ../..
./3rd/luamake/luamake rebuild

[clason]

Oh, and Git 2.13 apparently has

git clone --recurse-submodules=<path>

Maybe that can be used in the config to only recurse for luamake?

[clason]

Ok, I think the simplest thing is to just change the build instructions to

git submodule update --init --depth 1
git submodule update --init --depth 1 --recursive 3rd/luamake

This keeps the checkout nice and small while still getting everything needed to compile lua-language-server.

[clason]

(Might be nice to provide a simple script that does all necessary build steps -- (update submodules, build luamake, then lua-language-server with the right call for the current platform)?)

[sumneko]

Maybe just remove this submodule

[sumneko]

(Might be nice to provide a simple script that does all necessary build steps -- (update submodules, build luamake, then lua-language-server with the right call for the current platform)?)

Could you please provide a PR? Then I will modify the wiki.

[clason]

(Might be nice to provide a simple script that does all necessary build steps -- (update submodules, build luamake, then lua-language-server with the right call for the current platform)?)

Could you please provide a PR? Then I will modify the wiki.

I don't have enough platforms to test this on, so I'm probably not the best person to write this script. Also, I found out you only need one extra line to avoid the huge submodules, so a script is not really necessary. I think it's enough to change the wiki to use

git submodule update --init --depth 1
git submodule update --init --depth 1 --recursive 3rd/luamake

in place of git submodule update --init --recursive.