From 3.6.5 on, luarc is not being modified properly

[carlosala]

How are you using the lua-language-server?

NeoVim

Which OS are you using?

Linux

What is the issue affecting?

Libraries

Expected Behaviour

I expect my workspace libraries to be added to .luarc.json.

Actual Behaviour

.luarc.json is not being created nor modified at all. It also prompts for luassert addition to workspace, where I answer 1, yes and modify settings. It does not modifies them.

Reproduction steps

1. Open a lua file having workspace setting set up.
2. It will look for all workspace.
3. It should write in .luarc.json all the content.

Additional Notes

I tried and 3.6.4 was working, 3.6.5 and so on not. Maybe due to https://github.com/sumneko/lua-language-server/blob/4a9ab5b1ae9889e9732b53ad8cdf3b6db5394c3b/changelog.md?plain=1#L33

This is my config on nvim lspconfig:

Lua = {
  runtime = { version = "LuaJIT" },
  diagnostics = { globals = { "vim" } },
  workspace = { library = vim.api.nvim_get_runtime_file("", true) },
},

Log File

No response

[carlosala]

I also see I'm getting this error, it looks it's related:

[ERROR][2023-01-30 10:00:03] .../vim/lsp/rpc.lua:733	"rpc"	"lua-language-server"	"stderr"	"script/json-edit.lua:408: attempt to index a userdata value (local 'ast')
stack traceback:
\tscript/json-edit.lua:408: in function <script/json-edit.lua:407>
\t(...tail calls...)
\tscript/json-edit.lua:578: in function <script/json-edit.lua:570>
\t(...tail calls...)
\tscript/client.lua:349: in upvalue 'editConfigJson'
\tscript/client.lua:401: in upvalue 'tryModifyRC'
\tscript/client.lua:499: in function <script/client.lua:485>
\t[C]: in function 'xpcall'
\tscript/client.lua:485: in function 'client.setConfig'
\tscript/library.lua:467: in upvalue 'apply3rd'
\tscript/library.lua:488: in upvalue 'askFor3rd'
\tscript/library.lua:548: in function <script/library.lua:547>
"

[carlosala]

Thanks @sumneko! Could we get a new release soon so this applies to everyone? Thanks!

[sumneko]

Should in these days.

[carlosala]

Thanks!

[carlosala]

@sumneko v3.6.8 do not solve the issue for me 😢

[sumneko]

@sumneko v3.6.8 do not solve the issue for me 😢

Is the error gone?
Is the .luarc.json modified?

[carlosala]

The error is gone, but .luarc.json is not created nor modified (if existed before).

[carlosala]

@sumneko 3.6.9 do not solve the issue, and the error is still gone

[sumneko]

Please provide your .luarc.json

[carlosala]

It doesn't exist, I'd expect before to be created and filled due to my workspaces config, and also with luassert.
If I create an empty .luarc.json with just {} inside it don't push there all my workspace stuff from workspaces config and only pushes luassert. Even though, it keeps asking for adding luassert to it, it seems that the issue is that is not adding the workspaces stuff.

[sumneko]

If I create an empty .luarc.json with just {} inside it don't push there all my workspace stuff from workspaces config and only pushes luassert.

It is in designed, different configs will be merged in order.
I will check other issues you mentioned.