Skip to content

Update deps, replace Validateds with Eithers #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 2, 2023

Conversation

hoc081098
Copy link
Member

No description provided.

@hoc081098 hoc081098 added enhancement New feature or request deps labels Feb 19, 2023
@hoc081098 hoc081098 changed the title Update deps, replace Arrow's Eithers with Validateds Update deps, replace Arrow's Validateds with Eithers Feb 19, 2023
@hoc081098 hoc081098 changed the title Update deps, replace Arrow's Validateds with Eithers Update deps, replace Validateds with Eithers Feb 19, 2023
@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Merging #188 (a60a243) into master (f241a54) will decrease coverage by 0.21%.
The diff coverage is 72.15%.

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
- Coverage     52.77%   52.56%   -0.21%     
  Complexity       86       86              
============================================
  Files            48       48              
  Lines          1173     1191      +18     
  Branches        121      128       +7     
============================================
+ Hits            619      626       +7     
- Misses          530      541      +11     
  Partials         24       24              
Impacted Files Coverage Δ
...re/src/main/java/com/hoc/flowmvi/core/EitherNes.kt 0.00% <0.00%> (ø)
...wmvi/data/mapper/UserResponseToUserDomainMapper.kt 100.00% <ø> (ø)
...rc/main/java/com/hoc/flowmvi/domain/model/Email.kt 50.00% <ø> (ø)
...ain/java/com/hoc/flowmvi/domain/model/FirstName.kt 50.00% <ø> (ø)
...main/java/com/hoc/flowmvi/domain/model/LastName.kt 50.00% <ø> (ø)
...ain/java/com/hoc/flowmvi/domain/model/UserError.kt 16.66% <0.00%> (ø)
...in/java/com/hoc/flowmvi/ui/search/SearchAdapter.kt 0.00% <ø> (ø)
...-add/src/main/java/com/hoc/flowmvi/ui/add/AddVM.kt 93.97% <66.66%> (ø)
...in/java/com/hoc/flowmvi/data/UserRepositoryImpl.kt 90.80% <96.66%> (+4.21%) ⬆️
...ava/com/hoc/flowmvi/data/mapper/UserErrorMapper.kt 96.42% <100.00%> (+0.13%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hoc081098 hoc081098 merged commit 483a21a into master Mar 2, 2023
@hoc081098 hoc081098 deleted the deps_arrow_kotlin_others branch March 2, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant