Skip to content

Deployments: use proper media-type for in_progress/queued, inactive state #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Deployments: use proper media-type for in_progress/queued, inactive state #979

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ffefdc
Deployments: use correct media-type for in_progress/queued, inactive
staabm Mar 25, 2021
bf3eb1f
Update Deployment.php
staabm Mar 25, 2021
ca128f6
cs
staabm Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/Github/Api/Deployment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
*/
class Deployment extends AbstractApi
{
use AcceptHeaderTrait;

/**
* List deployments for a particular repository.
*
Expand Down Expand Up @@ -88,6 +90,15 @@ public function updateStatus($username, $repository, $id, array $params)
throw new MissingArgumentException(['state']);
}

// adjust media-type per github docs
// https://docs.github.com/en/rest/reference/repos#create-a-deployment-status
if ($params['state'] === 'inactive') {
$this->acceptHeaderValue = 'application/vnd.github.ant-man-preview+json';
}
if ($params['state'] === 'in_progress' || $params['state'] === 'queued') {
$this->acceptHeaderValue = 'application/vnd.github.flash-preview+json';
}

return $this->post('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/deployments/'.$id.'/statuses', $params);
}

Expand Down