Fix error in bc-check script #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we even need this script anymore? |
|
Yes we need this to support both v1 and v2 of httplug. As the bc break tool thinks the interface changes on some of the httplug interfaces are bc breaks, but we have to bc layers in place so it's not a bc break for our users. This script can be removed when we release a new major and remove support for httplug V1 |
Not since the last release was tagged? |
|
@GrahamCampbell Hmm you could actually have a point there, let me check this! Otherwise we should indeed remove the script, no need for the extra complexity then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #841