Skip to content

Add support for draft PRs #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 15, 2019
Merged

Add support for draft PRs #820

merged 5 commits into from
Nov 15, 2019

Conversation

selator
Copy link
Contributor

@selator selator commented Oct 25, 2019

Fixes #807

acrobat
acrobat requested changes Oct 31, 2019
View reviewed changes
@selator selator requested a review from acrobat November 13, 2019 16:10
acrobat
acrobat requested changes Nov 13, 2019
View reviewed changes
@acrobat
Copy link
Collaborator

acrobat commented Nov 13, 2019

One small remark, the rest of the PR is good! 👍

@selator selator requested a review from acrobat November 15, 2019 16:54
acrobat
acrobat requested changes Nov 15, 2019
View reviewed changes
@acrobat
Copy link
Collaborator

acrobat commented Nov 15, 2019

Sorry, 2 extra remarks I looked over last time!

@selator selator requested a review from acrobat November 15, 2019 17:46
@acrobat
Copy link
Collaborator

acrobat commented Nov 15, 2019

Thanks @selator!

@acrobat acrobat merged commit 005189c into KnpLabs:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat approved these changes

Assignees
No one assigned
Labels
needs-work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for draft pullrequests
3 participants
@selator @acrobat @ktoth2