Allow tags to be created without the tagger object. #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
approved these changes
Mar 16, 2019
Drop hhvm support
|
@owenconti can you rebase the PR against the current master? This will make travis pass again! |
…p-github-api into bug/create-tag-restrictions
…p-github-api into bug/create-tag-restrictions
|
@acrobat should be good now! |
|
Thanks @owenconti and congrats on your first contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub API does not require the
taggerobject when creating a new tag:https://developer.github.com/v3/git/tags/#create-a-tag-object
This PR updates the create tag method to only check if the
taggerproperties are set when thetaggerobject is passed.