Convert the issue assignee parameter to array #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
reviewed
Sep 5, 2018
lib/Github/Api/Issue/Assignees.php
Outdated
| @@ -57,6 +57,10 @@ public function add($username, $repository, $issue, array $parameters) | |||
| throw new MissingArgumentException('assignees'); | |||
| } | |||
|
|
|||
| if (!is_array($parameters['assignees'])) { | |||
| $parameters['assignees'] = [$parameters['assignees']]; | |||
There was a problem hiding this comment.
Add @trigger_error('Good message', E_USER_DEPRECATED)
There was a problem hiding this comment.
I've added a deprecation, is the message ok?
acrobat
force-pushed
the
fix-issue-assignee-parameter
branch
3 times, most recently
from
2fcc7b4 to
3399d3b
Compare
acrobat
force-pushed
the
fix-issue-assignee-parameter
branch
from
3399d3b to
6e9759c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assigneesparameter should be an array, this will return an exception in the near future. See #737