Add the repository transfer endpoint #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @m1guelpf! Can you just add docs entry for this endpoint and update the changelog to describe this added feature. |
|
@acrobat Done! |
Nyholm
requested changes
Mar 23, 2018
lib/Github/Api/Repo.php
Outdated
| * | ||
| * @return array | ||
| */ | ||
| public function transfer($username, $repository, $new_owner, $team_id = []) |
There was a problem hiding this comment.
We should use camelCase and not snake_case
There was a problem hiding this comment.
@GrahamCampbell Is there any configuration in StyleCI that would allow us to force camel case?
|
@Nyholm Fixed! |
Nyholm
approved these changes
Mar 23, 2018
acrobat
reviewed
Mar 25, 2018
doc/repos.md
Outdated
| ### Transfer a repo to another user | ||
|
|
||
| ```php | ||
| $currentTopics = $client->api('repo')->transfer('KnpLabs', 'php-github-api', 'github'); |
There was a problem hiding this comment.
Use a correct variable name (or remove it if the api does not return anything)
acrobat
reviewed
Mar 25, 2018
doc/repos.md
Outdated
| You can optionally assign some teams by passing an array with their ID's if you're transferring the repo to an organization: | ||
|
|
||
| ```php | ||
| $currentTopics = $client->api('repo')->transfer('KnpLabs', 'php-github-api', 'github', [1234]); |
acrobat
approved these changes
Mar 25, 2018
|
@acrobat Done! |
|
Thanks @m1guelpf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the repo transfer endpoint to the client.
Documentation: https://developer.github.com/v3/repos/#transfer-a-repository